chore: event_payload column can be JSONB or TEXT #5372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidddddarth
force-pushed
the
chore.jobsdbPayloadColumnType
branch
from
c053da4 to
c5c21e3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5372 +/- ##
==========================================
- Coverage 74.78% 74.76% -0.02%
==========================================
Files 440 440
Lines 61538 61607 +69
==========================================
+ Hits 46022 46062 +40
- Misses 12979 13001 +22
- Partials 2537 2544 +7 ☔ View full report in Codecov by Sentry. |
Sidddddarth
changed the title
ktgowtham
reviewed
Dec 26, 2024
Sidddddarth
force-pushed
the
chore.jobsdbPayloadColumnType
branch
from
f964bf8 to
5a4adff
Compare
lvrach
reviewed
Dec 27, 2024
jobsdb/migration.go
Outdated
| @@ -459,18 +459,85 @@ func (jd *Handle) getMigrationList(dsList []dataSetT) (migrateFrom []dsWithPendi | |||
| return | |||
| } | |||
|
|
|||
| func getColumnConversion(srcType, destType string) string { | |||
There was a problem hiding this comment.
Is it possible to find a universal way to do the mapping, that will always work?
Sidddddarth
force-pushed
the
chore.jobsdbPayloadColumnType
branch
from
e5e9442 to
b55615a
Compare
cisse21
force-pushed
the
chore.jobsdbPayloadColumnType
branch
from
0ee4339 to
1762246
Compare
cisse21
force-pushed
the
chore.jobsdbPayloadColumnType
branch
from
1762246 to
3bc24b4
Compare
cisse21
force-pushed
the
chore.jobsdbPayloadColumnType
branch
from
7808f82 to
935f63c
Compare
ktgowtham
reviewed
Jan 8, 2025
cisse21
approved these changes
Jan 9, 2025
This was referenced Jan 20, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
event_payloadcolumn in newly created jobs tables will beTEXTcolumns.Allows migrations from one type to the other, so changing from one to the other shouldn't fail. Changing back to
JSONBwould allow server processes to continue, however utility postgres functions likeunionjobsdbwould fail in case of bytea column.Not a reloadable selection.
Allowed creating
BYTEAcolumns but only for benchmark purposes.TEXTseems to be doing better and also avoids other character validation problems.Linear Ticket
Resolves PIPE-1649
Security